fix: resolve streaming clients hanging on security blocks (issue #355) #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yossiovadia
requested review from
Xunzhuo,
rootfs and
wangchen615
as code owners
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
|
|
@Xunzhuo @tao12345666333 @AkisAya PTAL, thanks |
|
can u share the demo for what it looks like in openwebui when security blocked now? |
|
@Xunzhuo I did, it's just above your comment |
|
Looks great, any demos for PII detection? |
|
Will do soon, i wiped out the deployment for other fixes/tests. |
|
|
@yossiovadia that's cool! can you fix the pre-commit? it is ready to go, thanks |
…-project#355) - Add streaming support to security response functions in response.go - Update CreateJailbreakViolationResponse() to return SSE format when isStreaming=true - Update CreatePIIViolationResponse() to return SSE format when isStreaming=true - Fix header consistency by using RawValue instead of Value for all headers - Update all call sites in request_handler.go to pass streaming context - Add comprehensive streaming tests to 05-jailbreak-test.py - Replace inappropriate test content with professional jailbreak testing patterns - Add TEST 5: Streaming jailbreak detection with SSE format validation - Add TEST 6: Streaming vs non-streaming consistency verification This resolves the issue where streaming clients like OpenWebUI would hang indefinitely when security violations occurred, as they expected SSE format but received JSON responses. Signed-off-by: Yossi Ovadia <[email protected]>
yossiovadia
force-pushed
the
fix/streaming-security-responses-355
branch
from
1438978 to
1ce14cc
Compare
rootfs
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue where streaming clients like OpenWebUI would hang indefinitely when security violations occurred, as they expected SSE format but received JSON responses.
Release Notes: No